Skip to content

feat: actions dropdown in admin user list #4188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

DavideIadeluca
Copy link
Contributor

@DavideIadeluca DavideIadeluca commented Feb 11, 2025

2.x port of #4054 with some minor differences

Progresses #4060

Changes proposed in this pull request:

  • Provide reusable actions dropdown
  • Use displayName instead of username in button title
  • Slightly adjust translation structure

Reviewers should focus on:

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@DavideIadeluca
Copy link
Contributor Author

Created a follow up issue for the actions dropdown not overflowing as expected: #4189. This is already an issue in 1.x and would be an issue if this PR is merged as it is right now. I feel like the approach to resolve this should first be discussed instead of shoehorned in here

@DavideIadeluca
Copy link
Contributor Author

DavideIadeluca commented Feb 11, 2025

Created another follow up ticket for issues with a translation: #4190

@DavideIadeluca DavideIadeluca marked this pull request as ready for review February 11, 2025 07:59
@DavideIadeluca DavideIadeluca requested a review from a team as a code owner February 11, 2025 07:59
@SychO9 SychO9 changed the title refactor(core): provide reusable dropdown in admin user list feat: actions dropdown in admin user list Feb 14, 2025
@SychO9 SychO9 added this to the 2.0.0-beta.3 milestone Feb 14, 2025
@SychO9 SychO9 merged commit b7bab28 into flarum:2.x Feb 14, 2025
21 checks passed
@imorland imorland deleted the di/admin-userlist-dropdown branch February 15, 2025 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants